Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xbar beta - Closing "Plugin browser..." does not close it #647

Closed
ramonmata opened this issue Mar 17, 2021 · 10 comments
Closed

xbar beta - Closing "Plugin browser..." does not close it #647

ramonmata opened this issue Mar 17, 2021 · 10 comments

Comments

@ramonmata
Copy link

When I try to close the Plugin browser window by using the mac os top left window buttons, nothing happens. The screen seems to go behind all other windows but stays open.

The workaround I have found is to use the "cmd + w"

regards!

@matryer
Copy link
Owner

matryer commented Mar 18, 2021

@ramonmata thanks for reporting - you're right, it's so weird.

@leaanthony our little plugin window is very disrespectful, and is outstaying its welcome.

  1. Run xbar
  2. Access "Plugin browser..." from the xbar menu
  3. Press the red dot to close the window
  4. Window goes to the background trying to hide, but the pesky little bugger is still there

@matryer
Copy link
Owner

matryer commented Mar 18, 2021

One workaround for now is to always leave it open :)

@thuss
Copy link

thuss commented Mar 18, 2021

Another workaround is to use Command-h to hide it

@ramonmata
Copy link
Author

Not familiar with Wails but maybe it allows to intercept the close event? and then app could hide the window.

@leaanthony
Copy link
Collaborator

Wow, are you saying all those times we tested it, we had other windows obscuring it? 😃 This has to be a fallout of the NSResponder change. Will investigate 👍

@leaanthony
Copy link
Collaborator

Fix pushed and will be included in next xbar release 👍

@matryer
Copy link
Owner

matryer commented Mar 19, 2021

OK I'll release now, thanks @leaanthony.

@matryer
Copy link
Owner

matryer commented Mar 19, 2021

@ramonmata please check out the latest release and let me know if it's better for you.

@ramonmata
Copy link
Author

@matryer Just tested the latest release and it is working great!

@matryer
Copy link
Owner

matryer commented Mar 19, 2021

Thanks, @ramonmata :)

@matryer matryer closed this as completed Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants