Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Removing pushers doesn't work in all cases when using worker mode #8925

Closed
manuroe opened this issue Dec 11, 2020 · 3 comments
Closed

Removing pushers doesn't work in all cases when using worker mode #8925

manuroe opened this issue Dec 11, 2020 · 3 comments
Assignees
Labels
z-bug (Deprecated Label) z-p2 (Deprecated Label)

Comments

@manuroe
Copy link
Contributor

manuroe commented Dec 11, 2020

Description

Element-iOS disables its pusher when the user logs out from the app. It makes a request to /pushers/set to empty its pushers.
But it cannot do this when its session is logged out from another device.
The user is logged out but the app continues to receive pushes. As the iOS system forces us to display a notification for every received push, the app continues to display notifications with more or less data.

Synapse should disable pushers for any logged out sessions.

Steps to reproduce

Steps to reproduce on iOS are described
element-hq/element-ios#3718

@manuroe manuroe changed the title Pusher should be disabled when a session is logged out Pushers should be disabled when the session is logged out Dec 11, 2020
@richvdh
Copy link
Member

richvdh commented Dec 14, 2020

ironically, apparently for email we have the opposite problem: #3696

@erikjohnston
Copy link
Member

It looks like we correctly call pusher_pool.remove_pushers_by_access_token, so I think this is a bug with workers where we don't correctly replicate the device deletion to the pusher? Maybe?

@erikjohnston erikjohnston added z-bug (Deprecated Label) z-p2 (Deprecated Label) labels Dec 15, 2020
@erikjohnston erikjohnston changed the title Pushers should be disabled when the session is logged out Removing pushers doesn't work in all cases when using worker mode Feb 3, 2021
@clokep
Copy link
Member

clokep commented Feb 24, 2021

I think this was fixed by #9465.

@clokep clokep closed this as completed Feb 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
z-bug (Deprecated Label) z-p2 (Deprecated Label)
Projects
None yet
Development

No branches or pull requests

4 participants