This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Disable captcha registration by default in tests #4839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4839 +/- ##
===========================================
+ Coverage 75.34% 75.36% +0.01%
===========================================
Files 340 340
Lines 34920 34920
Branches 5717 5717
===========================================
+ Hits 26312 26317 +5
+ Misses 6999 6990 -9
- Partials 1609 1613 +4 |
erikjohnston
approved these changes
Mar 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be confusing that you have to explicitly disable recaptcha auth when writing tests, as it's not the default in Synapse (
enable_registration_captchais set tofalsein our config file). This just bit @babolivier as he spent a while debugging a new test he had written.Suggest we set this to false by default to prevent the same from happening again.