Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

user search is totally hosed #4833

Closed
richvdh opened this issue Mar 8, 2019 · 4 comments
Closed

user search is totally hosed #4833

richvdh opened this issue Mar 8, 2019 · 4 comments
Assignees
@hawkowl
Labels
z-bug (Deprecated Label)

Comments

@richvdh
Copy link
Member

richvdh commented Mar 8, 2019

search transactions take multiple minutes, taking out the whole db. Why do we need to store the cross-product of all users in all public rooms?
@neilisfragile neilisfragile added z-bug (Deprecated Label) p1 labels Mar 8, 2019
@hawkowl
Copy link
Contributor

hawkowl commented Mar 11, 2019

to avoid people having to read the code: the cross product is so that we know why users are in the user directory, so that when they leave a room we can find out if they're in any other rooms and purge them from the user directory if not

@hawkowl hawkowl mentioned this issue Mar 12, 2019
Merged
@richvdh
Copy link
Member Author

richvdh commented Mar 15, 2019

fixed by #4846?

@richvdh richvdh closed this as completed Mar 15, 2019
@richvdh richvdh reopened this Mar 15, 2019
@richvdh
Copy link
Member Author

richvdh commented Mar 15, 2019

apparently not. It's not returning any results.

@hawkowl
Copy link
Contributor

hawkowl commented Mar 21, 2019

Searching seems happy, now, due to #4900, #4887, and #4864

@hawkowl hawkowl closed this as completed Mar 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hawkowl hawkowl

Labels
z-bug (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@neilisfragile @richvdh @hawkowl