This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Reword the sample config header to be less scary #4801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4801 +/- ##
==========================================
- Coverage 75.12% 73.72% -1.4%
==========================================
Files 340 340
Lines 34917 36511 +1594
Branches 5723 6192 +469
==========================================
+ Hits 26231 26919 +688
- Misses 7071 7913 +842
- Partials 1615 1679 +64 |
richvdh
approved these changes
Mar 5, 2019
There was a problem hiding this comment.
header looks good to me; thanks for clearing this up.
I've tweaked the newsfile to match that used for the original change, so that they can share a changelog entry come release time. Hopefully that will also stop the CI complaining about the missing trailing full-stop.
|
hah, except of course we need to actually regenerate the file. /me does so |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.