This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Clean ups in replication notifier #4799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I guess this was used once? It's not now, anyway.
Both (!) things that register as replication listeners do the right thing wrt logcontexts, so this is redundant.
Codecov Report
@@ Coverage Diff @@
## develop #4799 +/- ##
===========================================
+ Coverage 75.08% 75.15% +0.07%
===========================================
Files 340 340
Lines 34923 34898 -25
Branches 5723 5720 -3
===========================================
+ Hits 26223 26229 +6
+ Misses 7086 7054 -32
- Partials 1614 1615 +1 |
erikjohnston
approved these changes
Mar 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c732577 (Richard van der Hoff, 30 minutes ago)
Remove redundant PreserveLoggingContext
Both (!) things that register as replication listeners do the right thing
wrt logcontexts, so this is redundant.
daa10e3 (Richard van der Hoff, 34 minutes ago)
Remove unused
wait_for_replicationmethodI guess this was used once? It's not now, anyway.