Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Move server key queries to federation reader #4757

Merged
merged 3 commits into from
Feb 27, 2019

Conversation

erikjohnston
Copy link
Member

No description provided.

@erikjohnston erikjohnston marked this pull request as ready for review February 27, 2019 13:46
@erikjohnston erikjohnston requested a review from a team February 27, 2019 13:46
@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #4757 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #4757      +/-   ##
===========================================
+ Coverage    75.07%   75.08%   +0.01%     
===========================================
  Files          340      340              
  Lines        34892    34895       +3     
  Branches      5716     5717       +1     
===========================================
+ Hits         26195    26201       +6     
+ Misses        7081     7080       -1     
+ Partials      1616     1614       -2

1 similar comment
@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #4757 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #4757      +/-   ##
===========================================
+ Coverage    75.07%   75.08%   +0.01%     
===========================================
  Files          340      340              
  Lines        34892    34895       +3     
  Branches      5716     5717       +1     
===========================================
+ Hits         26195    26201       +6     
+ Misses        7081     7080       -1     
+ Partials      1616     1614       -2

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erikjohnston erikjohnston merged commit 46b0151 into develop Feb 27, 2019
@erikjohnston erikjohnston deleted the erikj/key_api_fed_readae branch January 9, 2020 15:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants