Logging improvements for the pusher #4691
Conversation
richvdh
commented
Feb 20, 2019
richvdh
commented
- Don't log massive exception stacktraces the entire time
- reduce the amount of logging in startup
| except Exception as e: | ||
| logger.warning( | ||
| "Failed to push event %s to %s: %s %s", | ||
| event.event_id, self.name, type(e), e, |
There was a problem hiding this comment.
I'm a bit cautious about catching all the exceptions here in case it masks actual programming exceptions, can we not catch HttpResponseException etc?
OTOH, it was already logging at warning, so this isn't the end of the world
There was a problem hiding this comment.
wellll....
normally I'd agree with you, but the exception that was causing a problem is a twisted.web._newclient.RequestGenerationFailed: [<twisted.python.failure.Failure twisted.internet.defer.CancelledError: >]. AFAICT that doesn't seem to be part of twisted's public interface, so it seems to be not a great idea to try and catch it here.
There was a problem hiding this comment.
Oh great. It also doesn't look like I added RequestSendFailed stuff to the normal http client either.
