Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Make linearizer more quiet #4507

Merged
merged 3 commits into from
Jan 29, 2019
Merged

Make linearizer more quiet #4507

merged 3 commits into from
Jan 29, 2019

Conversation

hawkowl
Copy link
Contributor

@hawkowl hawkowl commented Jan 29, 2019

It's like 25% of our logs and not very useful at INFO

@hawkowl hawkowl requested a review from a team January 29, 2019 10:17
@codecov-io
Copy link

Codecov Report

Merging #4507 into develop will decrease coverage by <.01%.
The diff coverage is 80%.

@@             Coverage Diff             @@
##           develop    #4507      +/-   ##
===========================================
- Coverage    74.75%   74.75%   -0.01%     
===========================================
  Files          336      336              
  Lines        34156    34156              
  Branches      5554     5554              
===========================================
- Hits         25535    25534       -1     
  Misses        7046     7046              
- Partials      1575     1576       +1

@erikjohnston
Copy link
Member

FTR, the reason why this was added was that it helped track down bugs where synapse would lock up entirely (due to one instances taking out the lock and then blocking).

I agree that they're really noisy.

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might find ourselves needing to turn them back up again (or replace them with something more targeted), but lgtm

@ara4n
Copy link
Member

ara4n commented Jan 29, 2019

tracing these (very noisy) lineariser logs was the only way that mjark & I were able to diagnose the locks which led to the federation meltdown of Dec 2016, fwiw. i subsequently have used them quite a lot to see which locks are causing deadlocks and meltdowns. i find myself echoing vdh's last comment.

@hawkowl hawkowl merged commit f815bd7 into develop Jan 29, 2019
@hawkowl hawkowl deleted the hawkowl/quiet-linearizer branch January 29, 2019 11:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants