Don't recommend :8448 to people on public_baseurl

[turt2live]

Pull Request Checklist

• Pull request is based on the develop branch
• Pull request includes a changelog file
• Pull request includes a sign off (N/A)

[aaronraimist]

Also here:

synapse/debian/homeserver.yaml

Line 79 in d731b75

# public_baseurl: https://example.com:8448/

I guess it's not in the docker config?

[turt2live]

That file doesn't exist on develop, so I assume it is being auto-generated now.

[codecov-io]

Codecov Report

Merging #4498 into develop will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4498      +/-   ##
===========================================
+ Coverage    74.73%   74.74%   +<.01%     
===========================================
  Files          336      336              
  Lines        34148    34148              
  Branches      5553     5553              
===========================================
+ Hits         25520    25523       +3     
- Misses        7049     7050       +1     
+ Partials      1579     1575       -4

[richvdh]

looks plausible, but assumes people have somehow forwarded port 443 to synapse. Was the existing config causing confusion?

[turt2live]

Yes, people keep breaking their riots because this endpoint causes a redirect. Even with the additional documentation, people keep sticking :8448 on the end because they think it is required.

[richvdh]

I'm unconvinced that this is going to be any better, but whatever.

[richvdh]

[also, once we require people to have proper certs on port 8448, does the problem go away?]

[turt2live]

[also, once we require people to have proper certs on port 8448, does the problem go away?]

Probably, assuming people have client listeners.