This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix Host header sent by MatrixFederationAgent #4468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the Host header logic down here so that (a) it is used if we reuse the agent elsewhere, and (b) we can mess about with it with .well-known.
erikjohnston
approved these changes
Jan 25, 2019
| headers = headers.copy() | ||
|
|
||
| if not headers.hasHeader(b'host'): | ||
| headers.addRawHeader(b'host', server_name_bytes) |
There was a problem hiding this comment.
I'm assuming header names are case insensitive here?
There was a problem hiding this comment.
yeah, twisted sorts that out for us.
Codecov Report
@@ Coverage Diff @@
## develop #4468 +/- ##
===========================================
- Coverage 74.77% 74.75% -0.02%
===========================================
Files 336 336
Lines 34023 34062 +39
Branches 5533 5540 +7
===========================================
+ Hits 25439 25462 +23
- Misses 7014 7026 +12
- Partials 1570 1574 +4 |
I made it and failed to commit it :/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the Host header logic down here so that (a) it is used if we reuse the
agent elsewhere, and (b) we can mess about with it with .well-known.