This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Config option to disable requesting MSISDN on registration #4423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4423 +/- ##
===========================================
+ Coverage 73.64% 73.65% +0.01%
===========================================
Files 300 300
Lines 29801 29803 +2
Branches 4896 4896
===========================================
+ Hits 21947 21952 +5
+ Misses 6417 6411 -6
- Partials 1437 1440 +3 |
richvdh
approved these changes
Jan 21, 2019
|
tested with ios and android - all good. Can't test fully against riot web since it hard codes the msisdn field. The redesign will solve with this, and should modify the form based on the server's capabilities. With that in mind I will merge but not enable on matrix.org |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.