Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

sign_request -> build_auth_headers #4408

Merged
merged 2 commits into from
Jan 17, 2019
Merged

sign_request -> build_auth_headers #4408

merged 2 commits into from
Jan 17, 2019

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jan 16, 2019

I just got very confused about the fact that the headers are only an output, not an input.

Just got very confused about the fact that the headers are only an output, not
an input.
@codecov-io
Copy link

codecov-io commented Jan 16, 2019

Codecov Report

Merging #4408 into develop will increase coverage by <.01%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4408      +/-   ##
===========================================
+ Coverage    73.65%   73.66%   +<.01%     
===========================================
  Files          300      300              
  Lines        29815    29816       +1     
  Branches      4897     4897              
===========================================
+ Hits         21961    21964       +3     
+ Misses        6412     6411       -1     
+ Partials      1442     1441       -1
Impacted Files Coverage Δ
synapse/handlers/identity.py 26.47% <0%> (ø) ⬆️
synapse/http/matrixfederationclient.py 84.09% <100%> (+0.06%) ⬆️
synapse/handlers/user_directory.py 71.08% <0%> (-0.31%) ⬇️
synapse/handlers/device.py 81.45% <0%> (+0.8%) ⬆️
synapse/util/file_consumer.py 82.45% <0%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f1a6a4...fde7836. Read the comment docs.

@richvdh richvdh changed the title sign_request -> build_auth_headers I just got very confused about the fact that the headers are only an output, not an input. sign_request -> build_auth_headers Jan 16, 2019
@richvdh richvdh requested a review from a team January 16, 2019 23:15
@richvdh richvdh merged commit 9feb5d0 into develop Jan 17, 2019
@richvdh richvdh deleted the rav/rename_sign_request branch December 1, 2020 12:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants