This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Use RequestSendFailed when fail to parse content type headers #4362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
approved these changes
Jan 8, 2019
There was a problem hiding this comment.
lgtm, but I suddenly realise that the docstrings on all the things that call _send_request need updating, because they carefully list all the exceptions and don't mention RequestSendFailed. That's not really part of this PR, but could you sort it out (either by updating this PR or opening a new one)?
|
Oh, so they do. I thought they didn't for some reason :S Will merge this and then fix in a separate PR just so that I can deploy this on matrix.org to see if it fixes most of the stack traces. |
|
(Fixed in #4368) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
RequestSendFailedexception here to indicate that this is an "expected" error, rather than an error in our app.