This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Make Docker image listen on ipv6 as well as ipv4 #4089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dekonnection
changed the title
|
please could you add a newsfile as per CONTRIBUTING.rst? |
dekonnection
force-pushed
the
master
branch
2 times, most recently
from
e363396 to
8bb67a1
Compare
Just added it :) Sorry for missing that, first contribution here. |
richvdh
reviewed
Oct 25, 2018
changelog.d/4089.feature
Outdated
| @@ -0,0 +1,4 @@ | |||
| Currently, the Docker image only listens on ipv4, making it unusable on ipv6-enabled setups. | |||
There was a problem hiding this comment.
ok, sorry: this file is what ends up in the changelog, so needs to be a succinct one-line summary. see https://github.com/matrix-org/synapse/blob/master/CHANGES.md#synapse-0337rc1-2018-10-15 for some examples, but basically, you want something more like "Configure the Docker image to listen on IPv6 addresses".
I'm sorry the CONTRIBUTING.rst doesn't make that clearer :/
Signed-off-by: Cédric Laudrel <dek@iono.me>
|
\o/ thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Docker image only listens on ipv4, making it unusable on ipv6-enabled setups.
This commit modifies the binding address from "0.0.0.0" to "::", so Synapse would listen on all addresses, ipv4 or ipv6 ones.
On ipv4-only setups, this has no undesired side-effect, everything works as previously, and synapse will listen on all ipv4 addresses.