This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Various cleanups in the federation client code #4031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improve logging: log things in the right order, include destination and txids in all log lines, don't log successful responses twice - Fix the docstring on TransportLayerClient.send_transaction - Don't use treq.request, which is overcomplicated for our purposes: just use a twisted.web.client.Agent. - simplify the logic for setting up the bodyProducer
richvdh
force-pushed
the
rav/cleanup_federation_client
branch
from
b47a851 to
544978b
Compare
erikjohnston
approved these changes
Oct 12, 2018
|
🤔 all the builds failed |
|
I take it all back |
erikjohnston
approved these changes
Oct 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve logging: log things in the right order, include destination and txids
in all log lines, don't log successful responses twice
Fix the docstring on TransportLayerClient.send_transaction
Don't use treq.request, which is overcomplicated for our purposes: just use a
twisted.web.client.Agent.
simplify the logic for setting up the bodyProducer