This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Improve performance of getting typing updates for replication #3794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fetching the list of all new typing notifications involved iterating over all rooms and comparing their serial. Lets move to using a stream change cache, like we do for other streams.
|
@matrixbot retest this please |
erikjohnston
force-pushed
the
erikj/faster_typing
branch
from
d3cbc91 to
1a24d4e
Compare
richvdh
reviewed
Sep 19, 2018
| if last_id < serial and serial <= current_id: | ||
| for room_id in changed_rooms: | ||
| serial = self._room_serials[room_id] | ||
| if last_id < serial <= current_id: |
| for room_id, serial in self._room_serials.items(): | ||
| if last_id < serial and serial <= current_id: | ||
| for room_id in changed_rooms: | ||
| serial = self._room_serials[room_id] |
There was a problem hiding this comment.
why do we bother to update and check room_serials as well as the stream change cache?
There was a problem hiding this comment.
Mainly because the stream change caches are bound in size and will drop old rooms. Agreed its a bit wasteful to have both, but I'm not sure the best way of amalgamating them without causing us to send down all typing notifications for old clients.
| last_id, | ||
| ) | ||
|
|
||
| if changed_rooms is None: |
There was a problem hiding this comment.
I can't see why this would happen.
There was a problem hiding this comment.
get_all_entities_changed can return None if last_id is sufficiently old?
richvdh
approved these changes
Sep 27, 2018
|
(oh, I was going to grumble about lack of comments to explain what was going on. nm.) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetching the list of all new typing notifications involved iterating
over all rooms and comparing their serial. Lets move to using a stream
change cache, like we do for other streams.