This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
LaterGauge needs to call thread safe functions #3722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkowl
reviewed
Aug 21, 2018
synapse/http/request_metrics.py
Outdated
| @@ -111,6 +112,9 @@ | |||
| # The set of all in flight requests, set[RequestMetrics] | |||
| _in_flight_requests = set() | |||
|
|
|||
| # Protects the _in_flight_requests set from concurrent accesss | |||
| _in_flight_reqeuests_lock = threading.Lock() | |||
hawkowl
reviewed
Aug 21, 2018
| for desc, processes in six.iteritems(_background_processes): | ||
| # We copy the dict so that it doesn't change from underneath us | ||
| with _bg_metrics_lock: | ||
| _background_processes_copy = dict(_background_processes) |
There was a problem hiding this comment.
I feel like dict(_background_processes) shouldn't require a lock?
There was a problem hiding this comment.
I'm completely failing to find any documentation about what is and isn't safe TBH
hawkowl
approved these changes
Aug 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prometheus collector can be run on a separate thread, and so the functions that the
LaterGaugecall should be thread safe. This PR fixes the two worst offenders, but there are still a bunch of other gauges who are doing a bit of naughty things