This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix client_reader worker being able to handle /context requests #3597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to handle /context/ requests on the client_reader worker without having to pull in all the various stream handlers (e.g. precence, typing, pushers etc). The only thing the token gets used for is pagination, and that ignores everything but the room portion of the token.
erikjohnston
commented
Jul 24, 2018
changelog.d/3597.misc
Outdated
| @@ -0,0 +1 @@ | |||
| Add support for client_reader to handle more APIs | |||
There was a problem hiding this comment.
I used .misc here on the assumption that this will automagically get merged with the changelog entry for #3555
There was a problem hiding this comment.
mmkay. it should probably be a .feature, then?
richvdh
approved these changes
Jul 24, 2018
changelog.d/3597.misc
Outdated
| @@ -0,0 +1 @@ | |||
| Add support for client_reader to handle more APIs | |||
There was a problem hiding this comment.
mmkay. it should probably be a .feature, then?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out I didn't test it as well as I thought....