Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Speed up _calculate_state_delta #3592

Merged
merged 4 commits into from
Jul 24, 2018
Merged

Speed up _calculate_state_delta #3592

merged 4 commits into from
Jul 24, 2018

Conversation

erikjohnston
Copy link
Member

During a simple test this gave about a ~20% speed up of the function.

@erikjohnston erikjohnston requested a review from richvdh July 24, 2018 10:14
richvdh
richvdh approved these changes Jul 24, 2018
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. So this will never return None any more. We should remove the if delta is not None line from the caller.

LGTM otherwise.

@richvdh richvdh assigned erikjohnston and unassigned richvdh Jul 24, 2018
@erikjohnston erikjohnston assigned richvdh and unassigned erikjohnston and richvdh Jul 24, 2018
@erikjohnston erikjohnston merged commit 0a8e4f3 into develop Jul 24, 2018
@erikjohnston erikjohnston deleted the erikj/speed_up_calculate_state_delta branch September 20, 2018 13:57
@erikjohnston erikjohnston restored the erikj/speed_up_calculate_state_delta branch September 20, 2018 13:57
@erikjohnston erikjohnston deleted the erikj/speed_up_calculate_state_delta branch September 20, 2018 13:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikjohnston @richvdh