This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Only get cached state from context in persist_event #3584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to bother pulling out the current state from the DB since until we know we have to. Checking the context for state is just an optimisation.
richvdh
approved these changes
Jul 23, 2018
synapse/events/snapshot.py
Outdated
|
|
||
| Returns: | ||
| dict[(str, str), str]|None: Returns None if state_group | ||
| is None, which happens when the associated event is an outlier. |
There was a problem hiding this comment.
... or if we don't have a cache, presumably
synapse/storage/events.py
Outdated
| state_groups_map[ctx.state_group] = yield ctx.get_current_state_ids(self) | ||
| current_state_ids = ctx.get_cached_current_state_ids() | ||
| if current_state_ids is not None: | ||
| state_groups_map[ctx.state_group] = current_state_ids |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to bother pulling out the current state from the DB since
until we know we have to. Checking the context for state is just an
optimisation.