Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix up auth check #3474

Merged
merged 3 commits into from
Jul 4, 2018
Merged

Fix up auth check #3474

merged 3 commits into from
Jul 4, 2018

Conversation

erikjohnston
Copy link
Member

No description provided.

@erikjohnston erikjohnston requested a review from a team July 2, 2018 10:42
richvdh
richvdh reviewed Jul 2, 2018
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, it would be good to know if this is fixing actual problems in production, and for there to be something in the newsfile.

@erikjohnston
Copy link
Member Author

These weren't being hit in synapse/production afaict, I only noticed when using it as a library.

Not sure that warrants a changelog entry?

@erikjohnston erikjohnston assigned richvdh and unassigned erikjohnston Jul 2, 2018
richvdh
richvdh approved these changes Jul 4, 2018
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fair. lack of tests makes me sad.

@richvdh richvdh assigned erikjohnston and unassigned richvdh Jul 4, 2018
@erikjohnston erikjohnston merged commit 40252d1 into develop Jul 4, 2018
@erikjohnston erikjohnston deleted the erikj/py3_auth branch September 20, 2018 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees

@erikjohnston erikjohnston

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikjohnston @richvdh