This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add metrics to track appservice transactions #3344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
commented
Jun 5, 2018
synapse/appservice/api.py
Outdated
| @@ -219,12 +238,15 @@ def push_bulk(self, service, events, txn_id=None): | |||
| args={ | |||
| "access_token": service.hs_token | |||
| }) | |||
| sent_transactions_counter.label(service.id).inc() | |||
There was a problem hiding this comment.
I'd rather this label was somewhat more human readable, but I don't think there is anything in service that tells us the name of the service so the ID is the best bet. Probably an oversight in the registration file to be honest.
There was a problem hiding this comment.
to be fair, the ID being a random string was a convention started with the js-bridge library. There's still quite a few bridges which have the default ID "telegram" or similar.
|
@richvdh are you okay to review this? |
|
This might be more in @hawkowl's department actually |
|
Apologies, hawkowl? 😇 |
|
Looks fine to me! |
|
Kewl, I'll merge then :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just adds some simple tracking from synapse to see how many transactions have been sent from the homeserver to an AS in prometheus.