This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
StreamChangeCache.get_all_changed_entities incorrect usage #14583
Labels
O-Frequent
Affects or can be seen by most users regularly or impacts most users' first experience
S-Minor
Blocks non-critical functionality, workarounds exist.
T-Defect
Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
The
get_all_changed_entities
returnsNone
in the case that the cache cannot provide information on the given stream ordering. Some of the callers treatNone
equivalent to[]
(which corresponds to no changes).Callers, checked do it correctly. Unchecked are either incorrect or maybe incorrect:
PresenceEventSource.get_new_events
PresenceEventSource._filter_all_presence_updates_for_user
TypingWriterHandler.get_all_typing_updates
DeviceWorkerStore.get_cached_device_list_changes
:SyncHandler._generate_sync_entry_for_device_list
DeviceWorkerStore.get_users_whose_devices_changed
(I'm fairly certain this is incorrect.)StreamChangeCache.get_entities_changed
The text was updated successfully, but these errors were encountered: