Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Stop using /_matrix/identity/api/v1/3pid/unbind #13171

Closed
richvdh opened this issue Jul 4, 2022 · 1 comment · Fixed by #13240
Closed

Stop using /_matrix/identity/api/v1/3pid/unbind #13171

richvdh opened this issue Jul 4, 2022 · 1 comment · Fixed by #13240
Labels
A-Spec-Compliance places where synapse does not conform to the spec P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution

Comments

@richvdh
Copy link
Member

richvdh commented Jul 4, 2022

/_matrix/identity/api/v1/3pid/unbind was removed from the spec over a year ago (msc2713); we should no longer be using it.

For context, it is called from IdentityHandler.try_unbind_threepid_with_id_server, whenever a user requests a threepid be unbound or their HS account be deleted.

Since the IS accepts requests without an id server access token to /_matrix/identity/v2/3pid/unbind, the solution here is just to switch to that.

(The spec requires that the IS accept requests requests signed by the homeserver which controls the user_id).

@richvdh richvdh added Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution A-Spec-Compliance places where synapse does not conform to the spec P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels Jul 4, 2022
@richvdh
Copy link
Member Author

richvdh commented Jul 4, 2022

This is part of #9677.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Spec-Compliance places where synapse does not conform to the spec P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant