Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Run mypy over docker directory #12190

Closed
DMRobertson opened this issue Mar 9, 2022 · 1 comment · Fixed by #12280 or #12528
Closed

Run mypy over docker directory #12190

DMRobertson opened this issue Mar 9, 2022 · 1 comment · Fixed by #12280 or #12528
Labels
good first issue Good for newcomers P4 (OBSOLETE: use S- labels.) Okay backlog: will not schedule, will accept patches T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@DMRobertson
Copy link
Contributor

There's a couple of scripts in there which it would be nice to typecheck.

  • change mypy.ini's files list to include docker
  • run mypy and see what errors crop up
  • fix them until none remain

There's the contrib directory too, but we don't promise to support that diligently.
@DMRobertson DMRobertson added good first issue Good for newcomers P4 (OBSOLETE: use S- labels.) Okay backlog: will not schedule, will accept patches T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. labels Mar 9, 2022
@watson28 watson28 mentioned this issue Mar 24, 2022
Merged
4 tasks
@DMRobertson DMRobertson linked a pull request Apr 8, 2022 that will close this issue
type docker folder #12280
Merged
4 tasks
@DMRobertson
Copy link
Contributor Author

DMRobertson commented Apr 8, 2022 •
edited
Loading

#12280 was a great start! I'd like to see this pass with disallow_untyped_defs = True too. But I couldn't see how to setup the config in a way which would apply to the docker directory. Perhaps something like #11302 would help?

@DMRobertson DMRobertson mentioned this issue Apr 22, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers P4 (OBSOLETE: use S- labels.) Okay backlog: will not schedule, will accept patches T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
1 participant
@DMRobertson