Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Stabilize support for MSC3288: room type on the store-invite API #11113

Closed
clokep opened this issue Oct 18, 2021 · 1 comment · Fixed by #12398
Closed

Stabilize support for MSC3288: room type on the store-invite API #11113

clokep opened this issue Oct 18, 2021 · 1 comment · Fixed by #12398
Assignees
@clokep
Labels
A-Spaces Hierarchical organization of rooms T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@clokep
Copy link
Member

clokep commented Oct 18, 2021

Once MSC3288 lands we should (at some point) switch to a stable identifier.

There's a single case to switch:

synapse/synapse/handlers/identity.py

Lines 879 to 880 in eb9ddc8

if room_type is not None:
invite_config["org.matrix.msc3288.room_type"] = room_type

We might want to send both the stable and unstable identifiers for a bit.
@clokep clokep added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Oct 18, 2021
@clokep clokep self-assigned this Oct 26, 2021
This was referenced Oct 26, 2021
Merged
Merged
@clokep clokep added the A-Spaces Hierarchical organization of rooms label Jan 14, 2022
@clokep
Copy link
Member Author

clokep commented Apr 6, 2022

Note that Synapse v1.47.0 (released on 2021-11-17) started sending both the unstable and stable identifier. I think we can drop it now.

This was referenced Apr 6, 2022
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@clokep clokep

Labels
A-Spaces Hierarchical organization of rooms T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the unstable identifier from MSC3288. matrix-org/synapse
1 participant
@clokep