Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

add Synapse-Trace-Id to the Access-Control-Allow-Headers response header #10890

Open
richvdh opened this issue Sep 23, 2021 · 1 comment
Open

add Synapse-Trace-Id to the Access-Control-Allow-Headers response header #10890

richvdh opened this issue Sep 23, 2021 · 1 comment
Labels
T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@richvdh
Copy link
Member

richvdh commented Sep 23, 2021

... so that javascript clients can read it and log it
@richvdh
Copy link
Member Author

richvdh commented Sep 23, 2021 •
edited
Loading

This header is returned as of #10199, but it seems javascript clients can't get to it unless it is added to the Access-Control-Allow-Headers response header, which is set at

synapse/synapse/http/server.py

Line 731 in bf72d10

b"X-Requested-With, Content-Type, Authorization, Date",
.

(we may also need to update the haproxy config on matrix.org, since that intercepts and handles OPTIONS requests)

@erikjohnston erikjohnston added the T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. label Sep 23, 2021
@matrixbot matrixbot mentioned this issue Dec 21, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richvdh @erikjohnston