Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Recent releases are not signed #10818

Closed
clokep opened this issue Sep 14, 2021 · 1 comment · Fixed by #10925
Closed

Recent releases are not signed #10818

clokep opened this issue Sep 14, 2021 · 1 comment · Fixed by #10925
Labels
P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@clokep
Copy link
Member

clokep commented Sep 14, 2021

It seems that recent releases of Synapse are not being signed any longer. I think this is due to the release script not properly signing the tags, but I'm unsure.

(Note that @anoadragon453 mentioned he has been doing the tags manually so his releases do have signatures on them.)

@erikjohnston mentioned this might be due to already having the necessary keys unlocked or not.

@erikjohnston
Copy link
Member

erikjohnston commented Sep 14, 2021

We probably need to add an option to:

repo.create_tag(tag_name, message=changes)

The docs for the github lib is at https://pygithub.readthedocs.io/en/latest/reference.html git lib is at https://gitpython.readthedocs.io/en/stable/

@callahad callahad added P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. labels Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants