Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove /send_relation support #10285

Closed
bwindels opened this issue Jun 30, 2021 · 5 comments · Fixed by #11682
Closed

Remove /send_relation support #10285

bwindels opened this issue Jun 30, 2021 · 5 comments · Fixed by #11682
Assignees
@clokep
Labels
A-Spec-Compliance places where synapse does not conform to the spec T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@bwindels
Copy link
Contributor

As it has been removed from MSC 2674. The code in question is at

synapse/synapse/rest/client/v2_alpha/relations.py

Line 87 in 4b965c8

async def on_PUT_or_POST(

@babolivier babolivier added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Jul 1, 2021
@deepbluev7 deepbluev7 mentioned this issue Oct 14, 2021
Merged
@clokep clokep added the A-Spec-Compliance places where synapse does not conform to the spec label Oct 14, 2021
@clokep
Copy link
Member

clokep commented Oct 14, 2021

We should likely check if this is called at all -- are any clients using it?

@deepbluev7
Copy link
Contributor

From what I know, neither any of the Elements, Nheko or Fluffy uses this. It might make sense to add logging to matrix.org for a few weeks to see if this is called and if nothing shows up, remove it. (I would be confused if Hydrogen would use this endpoint, considering who removed that endpoint from the MSC)

@DMRobertson DMRobertson added the X-Needs-Info This issue is blocked awaiting information from the reporter label Oct 14, 2021
@richvdh
Copy link
Member

richvdh commented Jan 4, 2022

I don't think this needs any extra info from the reporter

@richvdh richvdh removed the X-Needs-Info This issue is blocked awaiting information from the reporter label Jan 4, 2022
@clokep
Copy link
Member

clokep commented Jan 4, 2022

I was waiting for MSC2675 to merge to take a look at this, didn't realize that MSC2674 was what originally included this. I'll take a look!

@clokep clokep self-assigned this Jan 4, 2022
@clokep
Copy link
Member

clokep commented Jan 4, 2022

This was specifically removed from the MSC in matrix-org/matrix-doc@db6213b (#2674) from MSC2674.

@clokep clokep mentioned this issue Jan 4, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@clokep clokep

Labels
A-Spec-Compliance places where synapse does not conform to the spec T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the /send_relation endpoint. matrix-org/synapse
6 participants
@bwindels @clokep @richvdh @babolivier @DMRobertson @deepbluev7