From f6187dee307545aa15f3329d508e89ce24cba7f2 Mon Sep 17 00:00:00 2001
From: Richard van der Hoff <richard@matrix.org>
Date: Wed, 21 Jul 2021 16:05:21 +0100
Subject: [PATCH] Fix the tests-done Github Actions job

---
 .github/workflows/tests.yml | 19 ++++++++++++++++++-
 changelog.d/10444.misc      |  1 +
 2 files changed, 19 insertions(+), 1 deletion(-)
 create mode 100644 changelog.d/10444.misc

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index cef4439477b8..9759163290e9 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -347,7 +347,12 @@ jobs:
 
   # a job which marks all the other jobs as complete, thus allowing PRs to be merged.
   tests-done:
+    if: ${{ always() }}
     needs:
+      - lint
+      - lint-crlf
+      - lint-newsfile
+      - lint-sdist
       - trial
       - trial-olddeps
       - sytest
@@ -355,4 +360,16 @@ jobs:
       - complement
     runs-on: ubuntu-latest
     steps:
-      - run: "true"    
\ No newline at end of file
+      - name: Set build result
+        env:
+          NEEDS_CONTEXT: ${{ toJSON(needs) }}
+        # the `jq` incantation dumps out a series of "<job> <result>" lines
+        run: |
+          set -o pipefail
+          jq -r 'to_entries[] | [.key,.value.result] | join(" ")' \
+                          <<< $NEEDS_CONTEXT |
+              while read job result; do
+                  if [ "$result" != "success" ]; then
+                      echo "::set-failed ::Job $job returned $result"
+                  fi
+              done
diff --git a/changelog.d/10444.misc b/changelog.d/10444.misc
new file mode 100644
index 000000000000..c012e89f4bbb
--- /dev/null
+++ b/changelog.d/10444.misc
@@ -0,0 +1 @@
+Update the `tests-done` Github Actions status.