Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making cp_reconnect true by default #171

Closed
anoadragon453 opened this issue Mar 1, 2021 · 0 comments · Fixed by #179
Closed

Consider making cp_reconnect true by default #171

anoadragon453 opened this issue Mar 1, 2021 · 0 comments · Fixed by #179
Assignees

Comments

@anoadragon453
Copy link
Member

A somewhat recent change in Synapse enabled by default the behaviour of reconnecting to the Postgres database after losing connection automatically.

We likely want to consider doing the same for Sygnal.

sygnal/sygnal/sygnal.py

Lines 150 to 155 in e1b9eb8

if db_name == "psycopg2":
logger.info("Using postgresql database")
self.database_engine = "postgresql"
self.database = ConnectionPool(
"psycopg2", cp_reactor=self.reactor, **config["database"].get("args")
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants