Fix values in supported being duplicated #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
force-pushed
the
hs/fix-isupport-duplication
branch
from
9314786 to
20e6c25
Compare
Half-Shot
force-pushed
the
hs/fix-isupport-duplication
branch
from
7d92656 to
2121d29
Compare
Half-Shot
commented
Jul 27, 2023
| @@ -13,97 +14,123 @@ describe('Client', () => { | |||
| describe('joining channels', () => { | |||
| test('will get a join event from a newly joined user', async () => { | |||
| const { speaker, listener } = server.clients; | |||
| const expectedChannel = TestIrcServer.generateUniqueChannel('foobar'); | |||
There was a problem hiding this comment.
We were previously just using this channel for all tests, which broke when things happened concurrently.
AndrewFerr
reviewed
Jul 27, 2023
AndrewFerr
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty straightforward bug. I've added testing to ensure we catch it.