Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it more obvious that the spec is the primary resource, not the swagger viewer #268

Open
ara4n opened this issue Feb 25, 2018 · 8 comments
Labels
A-Tools Related to the process and tools for building the spec clarification An area where the expected behaviour is understood, but the spec could do with being more explicit

Comments

@ara4n
Copy link
Member

ara4n commented Feb 25, 2018

No description provided.

@richvdh
Copy link
Member

richvdh commented Feb 26, 2018

... why? people should be able to use the swagger if they like - it gives a better overview of the API.

@ara4n
Copy link
Member Author

ara4n commented Feb 26, 2018

you lose all the verbiage?
it's great as pure API reference, but not as a substitute for the spec itself.

@Half-Shot
Copy link
Contributor

Agreed on this one. There are many little details the swagger UI omits that creep up on you. Besides, the spec doc isn't a horrific read.

@richvdh
Copy link
Member

richvdh commented Feb 27, 2018

To be clear: what I am keen to avoid is a banner across the top of the swagger viewer saying "this is a lie, go and read the spec instead", as that would be an indication that we have failed with the swagger viewer. It sounds like that's not really what was proposed, however.

I would certainly support having links from the API descriptions to the relevant bits of the spec - though I'm not sure (a) what the mechanics are of getting the swagger viewer to display useful links, and (b) given that the description appears in both the viewer and the spec, how we achieve this without making the spec nonsensical.

@Half-Shot
Copy link
Contributor

Could we go halfway and have a link saying "for a more detailed and technical document, please see the CS API. We don't need to explictally or even remotely imply that "Swagger is bad. Do not use".

Doesn't have to be a big red banner or anything, just suggested reading.

@KitsuneRal
Copy link
Member

Instead of banners of any kind, I'd really appreciate links from specific parts in the description to the respective topics in The Spec. And I'm totally fine to have duplication across those. Linking from descriptions is a matter of OpenAPI 3, though?

@richvdh
Copy link
Member

richvdh commented Feb 27, 2018

Instead of banners of any kind, I'd really appreciate links from specific parts in the description to the respective topics in The Spec

Yes, this is what I am arguing for.

Linking from descriptions is a matter of OpenAPI 3, though?

Well, OpenAPI 3 is a thing we should have anyway.

@turt2live turt2live added the A-Tools Related to the process and tools for building the spec label Jul 19, 2018
@richvdh richvdh transferred this issue from matrix-org/matrix-spec-proposals Mar 1, 2022
@richvdh
Copy link
Member

richvdh commented Nov 22, 2022

I guess this is going to be better once #331 is fixed

@richvdh richvdh added the clarification An area where the expected behaviour is understood, but the spec could do with being more explicit label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Tools Related to the process and tools for building the spec clarification An area where the expected behaviour is understood, but the spec could do with being more explicit
Projects
None yet
Development

No branches or pull requests

5 participants