Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that invite->knock is *not* a valid transition #1717

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Clarify that invite->knock is *not* a valid transition #1717

merged 1 commit into from
Feb 21, 2024

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented Jan 23, 2024 •
edited by github-actions bot
Loading

This reverts #1175

See #1710

Signed-off-by: Kegan Dougal kegan@matrix.org

Preview: https://pr1717--matrix-spec-previews.netlify.app

@kegsay kegsay requested a review from a team as a code owner January 23, 2024 17:12
@kegsay kegsay mentioned this pull request Jan 23, 2024
Merged
@richvdh richvdh changed the title Clarify that invite->knock is not a valid transition Clarify that invite->knock is *not* a valid transition Jan 25, 2024
richvdh
richvdh approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with matrix-org/matrix-spec-proposals#4091: I think this is the right thing to do, but I would like opinions from others.

@richvdh
Copy link
Member

richvdh commented Jan 25, 2024

/cc @deepbluev7 and @Gnuxie on this as well

@richvdh
Copy link
Member

richvdh commented Jan 25, 2024

Also worth linking here: a complement test that asserts that what is implemented matches what this PR says: matrix-org/complement#702.

dbkr
dbkr approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I agree this is the correct way out of the mess, and doubly so with the complement test.

@turt2live turt2live merged commit c4e69d8 into matrix-org:main Feb 21, 2024
12 checks passed
This was referenced Feb 27, 2024
Merged
Closed
@MTRNord MTRNord mentioned this pull request Apr 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kegsay @richvdh @dbkr @turt2live