Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix npm release script #1713

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Fix npm release script #1713

merged 2 commits into from
Jan 17, 2024

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jan 17, 2024 •
edited
Loading

@t3chguy t3chguy requested a review from a team as a code owner January 17, 2024 09:45
@richvdh
Copy link
Member

richvdh commented Jan 17, 2024

I have a vague memory of us discussing this before, but I've forgotten everything. For me, and for future archaeologists, could you add some context here: has this always been broken, or did it break recently?

@richvdh
Copy link
Member

richvdh commented Jan 17, 2024

Is this the same as #1681? Or different?

@t3chguy
Copy link
Member Author

t3chguy commented Jan 17, 2024

@richvdh it likely has always been broken, all packages thus far have been manually deployed by me. Good spot on #1681 - updated OP

turt2live
turt2live approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's test it at the next release :)

@turt2live turt2live merged commit 650e691 into matrix-org:main Jan 17, 2024
12 checks passed
@t3chguy t3chguy deleted the patch-3 branch January 17, 2024 19:03
@t3chguy
Copy link
Member Author

t3chguy commented Jan 18, 2024 •
edited
Loading

Manually published 1.9 https://www.npmjs.com/package/@matrix-org/spec

turt2live
turt2live reviewed Mar 19, 2024
View reviewed changes
changelogs/internal/newsfragments/1713.misc
@@ -0,0 +1 @@
Fix npm release script for `@matrix-org/spec`.
Copy link
Member

@turt2live turt2live Mar 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somehow both CI and I missed this in review: .misc doesn't exist in the spec - we use .clarification

edit: I've fixed this on main as part of the release checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NPM publishing for emoji translations still broken
3 participants
@t3chguy @richvdh @turt2live