-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate unstable changelogs using towncrier #1340
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clearing code review while draft, also just a note to please update the release documentation to accomodate the change.
9e4306e
to
d64bed2
Compare
... which means we don't need to edit the top-level page for each release.
eeaebd1
to
306bda3
Compare
306bda3
to
1203ebe
Compare
*/}} | ||
|
||
{{ with .Page.Resources.Match "*.md" }} | ||
{{ range ((sort . "Name" "desc")) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this cause a problem when we get to v1.10 or v10.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bleh. yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed this by including the timestamp of when the changelog was generated in the file, and sorting by that instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise lgtm
Make sure we don't skip building the spec!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks :)
and doubly thanks for going back in time to find the dates of each release.
I mean they are written three lines below in each changelog, but I'll take the thanks :) |
considering that's more effort than I put into reading the changelogs, thank you 😇 |
Replace the current stack of hugo templates with a towncrier invocation. The main advantage of this is that it means that the "Changes since last release" section is consistent with the changelogs for the actual releases. This also changes the release process so that the changelog is generated before tagging, which means that the thing tagged v1.5 is actually the v1.5 spec. Fixes matrix-org#908.
Replace the current stack of hugo templates with a towncrier invocation. The main advantage of this is that it means that the "Changes since last release" section is consistent with the changelogs for the actual releases.
This also changes the release process so that the changelog is generated before tagging, which means that the thing tagged v1.5 is actually the v1.5 spec.
Fixes #908.
Suggest reviewing commit-by-commit.
Preview: https://pr1340--matrix-spec-previews.netlify.app