Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifications to AS spec, including MSC3905 #1305

Merged
merged 6 commits into from
Nov 8, 2022
Merged

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Oct 25, 2022

Primarily this is the spec for MSC3905, but I've also taken the opportunity to clean up the section a bit and move the definition out to a .yaml file.

Suggest reviewing commit-by-commit.

Preview: https://pr1305--matrix-spec-previews.netlify.app

@richvdh richvdh requested a review from a team as a code owner October 25, 2022 20:53
@turt2live turt2live requested a review from a team October 25, 2022 21:17
Co-authored-by: Travis Ralston <travisr@matrix.org>
data/api/application-service/definitions/registration.yaml Outdated Show resolved Hide resolved
data/api/application-service/definitions/registration.yaml Outdated Show resolved Hide resolved
Comment on lines +40 to +41
room IDs. An application service is said to be "interested" in a given event
if it matches any of the namespaces.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
room IDs. An application service is said to be "interested" in a given event
if it matches any of the namespaces.
room IDs. An application service is said to be "interested" in a given event
if it matches any of the namespace regex patterns.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely convinced this is an improvement in clarity, personally. The fact that namespaces are defined via regular expressions is a detail which I think is better left for the formal definition below rather in this overview.

(In any case, we'd want to say "namespace regular expressions" rather than "namespace regex patterns").

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"namespace regular expressions" sounds good to me 👍

I think it makes sense to mention when we're talking about matching. It's immediately apparent and understandable for anyone slightly familiar with regex how it matches then.

content/application-service-api.md Show resolved Hide resolved
content/application-service-api.md Outdated Show resolved Hide resolved
richvdh and others added 2 commits November 1, 2022 14:25
Co-authored-by: Eric Eastwood <madlittlemods@gmail.com>
@richvdh
Copy link
Member Author

richvdh commented Nov 1, 2022

@MadLittleMods thanks for your review: some great suggestions, which I've tried to incorporate with some light editing.

Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can see

@richvdh richvdh merged commit 1945589 into main Nov 8, 2022
@richvdh richvdh deleted the rav/appservice_users branch November 8, 2022 15:01
clokep pushed a commit to clokep/matrix-spec that referenced this pull request May 3, 2023
Primarily this is the spec for MSC3905, but I've also taken the opportunity to clean up the section a bit and move the definition out to a .yaml file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants