From 4cbe31a26f5fe761b27e11d44a126376ca99294c Mon Sep 17 00:00:00 2001
From: Michael Telatynski <7t3chguy@gmail.com>
Date: Tue, 16 Aug 2022 13:01:16 +0100
Subject: [PATCH] Fix soft crash around space hierarchy changing between spaces

---
 src/components/structures/SpaceHierarchy.tsx | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/src/components/structures/SpaceHierarchy.tsx b/src/components/structures/SpaceHierarchy.tsx
index cb0432efb5d..c22f1585f24 100644
--- a/src/components/structures/SpaceHierarchy.tsx
+++ b/src/components/structures/SpaceHierarchy.tsx
@@ -504,7 +504,7 @@ export const useRoomHierarchy = (space: Room): {
     loadMore(pageSize?: number): Promise<void>;
 } => {
     const [rooms, setRooms] = useState<IHierarchyRoom[]>([]);
-    const [hierarchy, setHierarchy] = useState<RoomHierarchy>();
+    const [roomHierarchy, setHierarchy] = useState<RoomHierarchy>();
     const [error, setError] = useState<Error | undefined>();
 
     const resetHierarchy = useCallback(() => {
@@ -526,15 +526,21 @@ export const useRoomHierarchy = (space: Room): {
     }));
 
     const loadMore = useCallback(async (pageSize?: number) => {
-        if (hierarchy.loading || !hierarchy.canLoadMore || hierarchy.noSupport || error) return;
-        await hierarchy.load(pageSize).catch(setError);
-        setRooms(hierarchy.rooms);
-    }, [error, hierarchy]);
+        if (roomHierarchy.loading || !roomHierarchy.canLoadMore || roomHierarchy.noSupport || error) return;
+        await roomHierarchy.load(pageSize).catch(setError);
+        setRooms(roomHierarchy.rooms);
+    }, [error, roomHierarchy]);
+
+    // Only return the hierarchy if it is for the space requested
+    let hierarchy = roomHierarchy;
+    if (hierarchy?.root !== space) {
+        hierarchy = undefined;
+    }
 
     return {
         loading: hierarchy?.loading ?? true,
         rooms,
-        hierarchy: hierarchy?.root === space ? hierarchy : undefined,
+        hierarchy,
         loadMore,
         error,
     };