From 84a1ba8a78fc129b5ef57a5ee111fd8dec0f68a8 Mon Sep 17 00:00:00 2001 From: Germain Souquet Date: Wed, 8 Jun 2022 12:29:40 +0100 Subject: [PATCH 1/3] Fix scroll jump issue with the composer --- res/css/views/rooms/_SendMessageComposer.scss | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/res/css/views/rooms/_SendMessageComposer.scss b/res/css/views/rooms/_SendMessageComposer.scss index 6805f158ed7..efa8a6c841c 100644 --- a/res/css/views/rooms/_SendMessageComposer.scss +++ b/res/css/views/rooms/_SendMessageComposer.scss @@ -31,6 +31,11 @@ limitations under the License. display: flex; flex-direction: column; + /* the below is required, without this some unexpected scroll jump + will occur when erasing the composer content or jumping to voice note + recording */ + min-height: 45px; + .mx_BasicMessageComposer_input { // this will center the contenteditable // in it's parent vertically From e3acb2e0b1f47eb30d17660f75e75864786d1856 Mon Sep 17 00:00:00 2001 From: Germain Souquet Date: Wed, 8 Jun 2022 14:39:09 +0100 Subject: [PATCH 2/3] Apply min-height to correct element --- res/css/views/rooms/_MessageComposer.scss | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/res/css/views/rooms/_MessageComposer.scss b/res/css/views/rooms/_MessageComposer.scss index 0d714f68fc0..5c34f78a8be 100644 --- a/res/css/views/rooms/_MessageComposer.scss +++ b/res/css/views/rooms/_MessageComposer.scss @@ -27,6 +27,11 @@ limitations under the License. "composer controls" auto / 1fr auto; + /* the below is required, without this some unexpected scroll jump + will occur when erasing the composer content or jumping to voice note + recording */ + min-height: 45px; + .mx_ReplyPreview { grid-area: reply; } From f640590ef61562abd706be212f9e8af08c58b117 Mon Sep 17 00:00:00 2001 From: Germain Souquet Date: Wed, 8 Jun 2022 14:46:57 +0100 Subject: [PATCH 3/3] Remove rogue css in SendMessageComposer --- res/css/views/rooms/_SendMessageComposer.scss | 5 ----- 1 file changed, 5 deletions(-) diff --git a/res/css/views/rooms/_SendMessageComposer.scss b/res/css/views/rooms/_SendMessageComposer.scss index efa8a6c841c..6805f158ed7 100644 --- a/res/css/views/rooms/_SendMessageComposer.scss +++ b/res/css/views/rooms/_SendMessageComposer.scss @@ -31,11 +31,6 @@ limitations under the License. display: flex; flex-direction: column; - /* the below is required, without this some unexpected scroll jump - will occur when erasing the composer content or jumping to voice note - recording */ - min-height: 45px; - .mx_BasicMessageComposer_input { // this will center the contenteditable // in it's parent vertically