Expose express app #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
commented
Sep 4, 2020
| "prepublishOnly": "npm run build", | ||
| "build": "tsc --project tsconfig.json" | ||
| "build": "tsc --project tsconfig.json", | ||
| "prepare": "npm run build" |
There was a problem hiding this comment.
This has also changed. This means the package should build on local install (only) automatically, rather than just publish.
Half-Shot
commented
Sep 4, 2020
| @@ -114,13 +114,9 @@ export class AppService extends EventEmitter { | |||
| this.server = serverApp.listen(port, hostname, backlog, callback); | |||
| return; | |||
| } | |||
| return new Promise((resolve, reject) => { | |||
| this.server = serverApp.listen(port, hostname, backlog, (err: Error|null) => { | |||
There was a problem hiding this comment.
The latest types for express removed the err parameter.
There was a problem hiding this comment.
That comes from Node's server.listen().
Looks like nowadays you're either waiting from an listening or error event.
server.on('listen', callback) is the same as the callback parameter.
There was a problem hiding this comment.
I've tweaked it so we listen for error. It was a bit tedious because serverApp might either be a Server or an Application, but I think we're good now.
This was referenced Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of bridges add their own paths, so let's expose the express app so they don't have to hack around it.