Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "enter" from matrix-messages #1079

Closed
natrius opened this issue Jul 2, 2020 · 6 comments
Closed

Remove "enter" from matrix-messages #1079

natrius opened this issue Jul 2, 2020 · 6 comments

Comments

@natrius
Copy link

natrius commented Jul 2, 2020

Hello,
enter should be removed if a message is sent to irc as IRC does not seem to process enter at all. This results in an link and this annoys a lot of people. I mean, now i know it and so i don't use enter anymore (if i think about that).

I'm not sure if this is possible and if you need more information, please tell.

Best regards

@Half-Shot
Copy link
Contributor

I'm not sure what you mean by "enter". I'm also really not sure what you mean by links either. Could you show a screenshot as an example?

@natrius
Copy link
Author

natrius commented Jul 6, 2020

https://en.wikipedia.org/wiki/Enter_key When pressing shift-enter it is possible to create a paragraph in one message. When this is done, the guys in IRC will get a link to an matrix.org site where the message is stored. Unfortunately i was not able to reproduce it right now. The text got split into 3 seperate texts for IRC. I'm not completely sure right now.

@Half-Shot
Copy link
Contributor

Oh you're asking to drop the line splitting feature. Yes, when users send messages with lots of paragraphs it causes issues because sending huge blocks of text to IRC is frowned upon. In order to combat this, we permit a maximum of 3 lines / (or ~500 characters) before it gives you a link to the message in order to reduce spam.

Certainly we could improve this behaviour, but the behaviour isn't going to be removed.

@natrius
Copy link
Author

natrius commented Jul 7, 2020

Not removed either.

The problem was, when opening this ticket, i wrote a message, entered one "shift-enter" for a paragraph and the guys in IRC got a link and not a split message (that would be 2 seperate messages out of mine with one paragraph).

An esxample is

11:54:22 * Negreheb sent a long message: < https://matrix.org/_matrix/media/r0/download/matrix.org/vLoxywNKYeFYStEKJZMFkuht >

The link is working and is provided by matrix. And i have written more without any break. With the last test it was because of the "shift-enter" and not the lenght. Or the "shift-enter" added so much length i reached the max-length, because one test last time with

test
enter
test

was correctly split into three sperate message like you said.

So, now i'm confused to be honest what length creates what behaviour.

@Half-Shot
Copy link
Contributor

Because the line splitter allows a maximum of 3 lines. Have you tried doing 4 lines?

@natrius
Copy link
Author

natrius commented Jul 9, 2020

Ah, i see https://github.com/matrix-org/matrix-appservice-irc/blob/master/config.sample.yaml there the 3 lines as default. Basically this resolves imho in this #701 ticket. Thanks for your help :)

@natrius natrius closed this as completed Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants