Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to use custom html code in a div container or an angular directive ? #27

Closed
cheikhnadiouf opened this issue Feb 18, 2016 · 9 comments

Comments

@cheikhnadiouf
Copy link

How can we customize an html code message notification in the body of a page like a div container or an angular directive ?

@matowens
Copy link
Owner

Hey Stylemaker, that's a really good question. I don't think you'd be able to do that with ng-notify in it's current state, it currently just appends itself to the page's body tag. I've had another person ask the same thing recently, I'll dig around a bit to see what it would require for us to do that. If you have any thoughts or ideas, please share them in here, too.

@matowens
Copy link
Owner

@systemaker is this inline with what you were talking about?

http://codepen.io/matowens/full/XXwoGV/

I just threw together a rough prototype, I'll work on cleaning it up and potentially creating a new release with it this weekend. I'd like to know what your thoughts are before I start doing that, though, just to make sure we're on the same page.

@sinsunsan
Copy link

By comparison with the actual implementation,

  • you add the possibility to choose a custom div, and not only the full screen
  • you add the possibility to have multiple alerts (?) Or this possibility already exists ?

Do the div need a specific layout, css ... for you alert to display correctly ?
Is it a sub directive ? we need to place on the div ?

@cheikhnadiouf
Copy link
Author

right ,
it is the new stuff i was looking for :

  • add the possibility to choose a custom div, and not only the full screen
    • add the possibility to have multiple alerts

thanks to implement it as a new feature in this module .

@cheikhnadiouf
Copy link
Author

Hello,
any news about this feature ?

@matowens
Copy link
Owner

matowens commented Apr 6, 2016

@systemaker it's all but done. just need to update the test cases and do some eyeball testing, then it should be ready to roll. expect something in the next couple of days.

@matowens matowens mentioned this issue Apr 8, 2016
@matowens
Copy link
Owner

matowens commented Apr 8, 2016

Update should be available for use. There was a fair amount of refactoring involved so it wouldn't surprise me if there were a few issues here and there. Let me know if you run into anything odd.

@matowens matowens closed this as completed Apr 8, 2016
@matowens
Copy link
Owner

matowens commented Apr 8, 2016

Check demo for example using target.

http://matowens.github.io/ng-notify/

@cheikhnadiouf
Copy link
Author

Great, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants