From 33aeed2914be990ce367a059a0b7c3d07df24a38 Mon Sep 17 00:00:00 2001 From: Kapil Gupta Date: Mon, 19 Aug 2024 17:16:42 +0530 Subject: [PATCH 01/11] add skip reason --- .../+ciplugins/+github/BuildSummaryPlugin.m | 51 ++++++++++++++----- src/buildSummary.ts | 30 ++++++++--- 2 files changed, 59 insertions(+), 22 deletions(-) diff --git a/plugins/+ciplugins/+github/BuildSummaryPlugin.m b/plugins/+ciplugins/+github/BuildSummaryPlugin.m index 1eed7a1..ab694fc 100644 --- a/plugins/+ciplugins/+github/BuildSummaryPlugin.m +++ b/plugins/+ciplugins/+github/BuildSummaryPlugin.m @@ -2,27 +2,50 @@ % Copyright 2024 The MathWorks, Inc. + properties + fID + taskDetails = []; + end + methods (Access=protected) - function runTaskGraph(plugin, pluginData) + [plugin.fID, msg] = fopen(fullfile(getenv("RUNNER_TEMP") ,"buildSummary" + getenv("GITHUB_RUN_ID") + ".json"), "w"); + runTaskGraph@matlab.buildtool.plugins.BuildRunnerPlugin(plugin, pluginData); - [fID, msg] = fopen(fullfile(getenv("RUNNER_TEMP") ,"buildSummary" + getenv("GITHUB_RUN_ID") + ".json"), "w"); - if fID == -1 + if plugin.fID == -1 warning("ciplugins:github:BuildSummaryPlugin:UnableToOpenFile","Unable to open a file required to create the MATLAB build summary table: %s", msg); else - closeFile = onCleanup(@()fclose(fID)); - taskDetails = struct(); - for idx = 1:numel(pluginData.TaskResults) - taskDetails(idx).name = pluginData.TaskResults(idx).Name; - taskDetails(idx).description = pluginData.TaskGraph.Tasks(idx).Description; - taskDetails(idx).failed = pluginData.TaskResults(idx).Failed; - taskDetails(idx).skipped = pluginData.TaskResults(idx).Skipped; - taskDetails(idx).duration = string(pluginData.TaskResults(idx).Duration); - end - s = jsonencode(taskDetails); - fprintf(fID, "%s",s); + closeFile = onCleanup(@()fclose(plugin.fID)); + s = jsonencode(plugin.taskDetails); + fprintf(plugin.fID, "%s",s); end end + + function runTask(plugin, pluginData) + runTask@matlab.buildtool.plugins.BuildRunnerPlugin(plugin, pluginData); + + taskDetail = plugin.getCommonTaskData(pluginData); + plugin.taskDetails = [plugin.taskDetails, taskDetail]; + end + + function skipTask(plugin, pluginData) + skipTask@matlab.buildtool.plugins.BuildRunnerPlugin(plugin, pluginData); + + taskDetail = plugin.getCommonTaskData(pluginData); + taskDetail.skipReason = pluginData.SkipReason; + plugin.taskDetails = [plugin.taskDetails, taskDetail]; + end + end + + methods(Static, Access=private) + function taskDetail = getCommonTaskData(pluginData) + taskDetail = struct(); + taskDetail.name = pluginData.TaskResults.Name; + taskDetail.description = pluginData.TaskGraph.Tasks.Description; + taskDetail.failed = pluginData.TaskResults.Failed; + taskDetail.skipped = pluginData.TaskResults.Skipped; + taskDetail.duration = string(pluginData.TaskResults.Duration); + end end end \ No newline at end of file diff --git a/src/buildSummary.ts b/src/buildSummary.ts index edc9ebf..86913ff 100644 --- a/src/buildSummary.ts +++ b/src/buildSummary.ts @@ -3,13 +3,14 @@ import * as core from "@actions/core"; import { join } from 'path'; import { readFileSync, unlinkSync, existsSync } from 'fs'; -export interface Task { - name: string; - description: string; - failed: boolean; - skipped: boolean; - duration: string; -} +// export interface Task { +// name: string; +// description: string; +// failed: boolean; +// skipped: boolean; +// skipReason: string; +// duration: string; +// } export function writeSummary(taskSummaryTableRows: string[][]) { try { @@ -26,7 +27,7 @@ export function getSummaryRows(buildSummary: string): any[] { if (t.failed) { return [t.name, '🔴 Failed', t.description, t.duration.toString()]; } else if (t.skipped) { - return [t.name, '🔵 Skipped', t.description, t.duration.toString()]; + return [t.name, '🔵 Skipped' + ' (' + interpretSkipReason(t.skipReason) + ')', t.description, t.duration.toString()]; } else { return [t.name, '🟢 Success', t.description, t.duration.toString()]; } @@ -34,6 +35,19 @@ export function getSummaryRows(buildSummary: string): any[] { return rows; } +export function interpretSkipReason(skipReason: string){ + switch(skipReason) { + case "UpToDate": + return "Up-To-Date"; + case "UserSpecified": + return "User Specified"; + case "DependencyFailed": + return "Dependency Failed"; + default: + return skipReason; + } +} + export function processAndDisplayBuildSummary() { const runId = process.env.GITHUB_RUN_ID || ''; const runnerTemp = process.env.RUNNER_TEMP || ''; From 2c7cf944efa11a21c81a352e16b39bb1d800984f Mon Sep 17 00:00:00 2001 From: Kapil Gupta Date: Mon, 19 Aug 2024 17:20:54 +0530 Subject: [PATCH 02/11] update test --- src/buildSummary.unit.test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/buildSummary.unit.test.ts b/src/buildSummary.unit.test.ts index 6a97852..fd1e39f 100644 --- a/src/buildSummary.unit.test.ts +++ b/src/buildSummary.unit.test.ts @@ -15,7 +15,7 @@ describe('summaryGeneration', () => { it('should process and return summary rows for valid JSON with different task statuses', () => { const mockBuildSummary = JSON.stringify([ { name: 'Task 1', failed: true, skipped: false, description: 'Task 1 description', duration: '00:00:10' }, - { name: 'Task 2', failed: false, skipped: true, description: 'Task 2 description', duration: '00:00:20' }, + { name: 'Task 2', failed: false, skipped: true, skipReason: 'UserSpecified', description: 'Task 2 description', duration: '00:00:20' }, { name: 'Task 3', failed: false, skipped: false, description: 'Task 3 description', duration: '00:00:30' } ]); @@ -23,7 +23,7 @@ describe('summaryGeneration', () => { expect(result).toEqual([ ['Task 1', '🔴 Failed', 'Task 1 description', '00:00:10'], - ['Task 2', '🔵 Skipped', 'Task 2 description', '00:00:20'], + ['Task 2', '🔵 Skipped (User Specified)', 'Task 2 description', '00:00:20'], ['Task 3', '🟢 Success', 'Task 3 description', '00:00:30'] ]); }); From 816f586cea63ece1314b001d0bef563b9dc9fd8d Mon Sep 17 00:00:00 2001 From: Kapil Gupta Date: Mon, 19 Aug 2024 18:34:00 +0530 Subject: [PATCH 03/11] fix build summary plugin --- plugins/+ciplugins/+github/BuildSummaryPlugin.m | 14 ++++++-------- src/buildSummary.ts | 9 --------- 2 files changed, 6 insertions(+), 17 deletions(-) diff --git a/plugins/+ciplugins/+github/BuildSummaryPlugin.m b/plugins/+ciplugins/+github/BuildSummaryPlugin.m index ab694fc..7677a36 100644 --- a/plugins/+ciplugins/+github/BuildSummaryPlugin.m +++ b/plugins/+ciplugins/+github/BuildSummaryPlugin.m @@ -3,22 +3,20 @@ % Copyright 2024 The MathWorks, Inc. properties - fID - taskDetails = []; + taskDetails = {}; end - + methods (Access=protected) function runTaskGraph(plugin, pluginData) - [plugin.fID, msg] = fopen(fullfile(getenv("RUNNER_TEMP") ,"buildSummary" + getenv("GITHUB_RUN_ID") + ".json"), "w"); - runTaskGraph@matlab.buildtool.plugins.BuildRunnerPlugin(plugin, pluginData); - if plugin.fID == -1 + [fID, msg] = fopen(fullfile(getenv("RUNNER_TEMP") ,"buildSummary" + getenv("GITHUB_RUN_ID") + ".json"), "w"); + if fID == -1 warning("ciplugins:github:BuildSummaryPlugin:UnableToOpenFile","Unable to open a file required to create the MATLAB build summary table: %s", msg); else - closeFile = onCleanup(@()fclose(plugin.fID)); + closeFile = onCleanup(@()fclose(fID)); s = jsonencode(plugin.taskDetails); - fprintf(plugin.fID, "%s",s); + fprintf(fID, "%s",s); end end diff --git a/src/buildSummary.ts b/src/buildSummary.ts index 86913ff..4d8246f 100644 --- a/src/buildSummary.ts +++ b/src/buildSummary.ts @@ -3,15 +3,6 @@ import * as core from "@actions/core"; import { join } from 'path'; import { readFileSync, unlinkSync, existsSync } from 'fs'; -// export interface Task { -// name: string; -// description: string; -// failed: boolean; -// skipped: boolean; -// skipReason: string; -// duration: string; -// } - export function writeSummary(taskSummaryTableRows: string[][]) { try { core.summary From 65e8022d2945567dd7124414a89d3eb9088eb3fe Mon Sep 17 00:00:00 2001 From: Kapil Gupta Date: Tue, 20 Aug 2024 11:39:32 +0530 Subject: [PATCH 04/11] Add 25a enum name compatibility --- src/buildSummary.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/buildSummary.ts b/src/buildSummary.ts index 4d8246f..20cca6c 100644 --- a/src/buildSummary.ts +++ b/src/buildSummary.ts @@ -32,6 +32,8 @@ export function interpretSkipReason(skipReason: string){ return "Up-To-Date"; case "UserSpecified": return "User Specified"; + case "UserRequested": + return "User Requested"; case "DependencyFailed": return "Dependency Failed"; default: From 2c9e673fd2077a99d6512ab6e7342ae3da225b5a Mon Sep 17 00:00:00 2001 From: Kapil Gupta Date: Wed, 21 Aug 2024 12:27:09 +0530 Subject: [PATCH 05/11] update as per review comments --- .../+ciplugins/+github/BuildSummaryPlugin.m | 32 +++++++++---------- src/buildSummary.ts | 14 ++++---- 2 files changed, 22 insertions(+), 24 deletions(-) diff --git a/plugins/+ciplugins/+github/BuildSummaryPlugin.m b/plugins/+ciplugins/+github/BuildSummaryPlugin.m index 7677a36..1304b94 100644 --- a/plugins/+ciplugins/+github/BuildSummaryPlugin.m +++ b/plugins/+ciplugins/+github/BuildSummaryPlugin.m @@ -3,7 +3,7 @@ % Copyright 2024 The MathWorks, Inc. properties - taskDetails = {}; + TaskDetails = {}; end methods (Access=protected) @@ -15,7 +15,7 @@ function runTaskGraph(plugin, pluginData) warning("ciplugins:github:BuildSummaryPlugin:UnableToOpenFile","Unable to open a file required to create the MATLAB build summary table: %s", msg); else closeFile = onCleanup(@()fclose(fID)); - s = jsonencode(plugin.taskDetails); + s = jsonencode(plugin.TaskDetails); fprintf(fID, "%s",s); end end @@ -23,27 +23,25 @@ function runTaskGraph(plugin, pluginData) function runTask(plugin, pluginData) runTask@matlab.buildtool.plugins.BuildRunnerPlugin(plugin, pluginData); - taskDetail = plugin.getCommonTaskData(pluginData); - plugin.taskDetails = [plugin.taskDetails, taskDetail]; + taskDetail = getCommonTaskData(pluginData); + plugin.TaskDetails = [plugin.TaskDetails, taskDetail]; end function skipTask(plugin, pluginData) skipTask@matlab.buildtool.plugins.BuildRunnerPlugin(plugin, pluginData); - taskDetail = plugin.getCommonTaskData(pluginData); + taskDetail = getCommonTaskData(pluginData); taskDetail.skipReason = pluginData.SkipReason; - plugin.taskDetails = [plugin.taskDetails, taskDetail]; - end - end - - methods(Static, Access=private) - function taskDetail = getCommonTaskData(pluginData) - taskDetail = struct(); - taskDetail.name = pluginData.TaskResults.Name; - taskDetail.description = pluginData.TaskGraph.Tasks.Description; - taskDetail.failed = pluginData.TaskResults.Failed; - taskDetail.skipped = pluginData.TaskResults.Skipped; - taskDetail.duration = string(pluginData.TaskResults.Duration); + plugin.TaskDetails = [plugin.TaskDetails, taskDetail]; end end +end + +function taskDetail = getCommonTaskData(pluginData) + taskDetail = struct(); + taskDetail.name = pluginData.TaskResults.Name; + taskDetail.description = pluginData.TaskGraph.Tasks.Description; + taskDetail.failed = pluginData.TaskResults.Failed; + taskDetail.skipped = pluginData.TaskResults.Skipped; + taskDetail.duration = string(pluginData.TaskResults.Duration); end \ No newline at end of file diff --git a/src/buildSummary.ts b/src/buildSummary.ts index 20cca6c..55063ee 100644 --- a/src/buildSummary.ts +++ b/src/buildSummary.ts @@ -16,11 +16,11 @@ export function writeSummary(taskSummaryTableRows: string[][]) { export function getSummaryRows(buildSummary: string): any[] { const rows = JSON.parse(buildSummary).map((t: any) => { if (t.failed) { - return [t.name, '🔴 Failed', t.description, t.duration.toString()]; + return [t.name, '🔴 Failed', t.description, t.duration]; } else if (t.skipped) { - return [t.name, '🔵 Skipped' + ' (' + interpretSkipReason(t.skipReason) + ')', t.description, t.duration.toString()]; + return [t.name, '🔵 Skipped' + ' (' + interpretSkipReason(t.skipReason) + ')', t.description, t.duration]; } else { - return [t.name, '🟢 Success', t.description, t.duration.toString()]; + return [t.name, '🟢 Success', t.description, t.duration]; } }); return rows; @@ -29,13 +29,13 @@ export function getSummaryRows(buildSummary: string): any[] { export function interpretSkipReason(skipReason: string){ switch(skipReason) { case "UpToDate": - return "Up-To-Date"; + return "up-to-date"; case "UserSpecified": - return "User Specified"; + return "user specified"; case "UserRequested": - return "User Requested"; + return "user requested"; case "DependencyFailed": - return "Dependency Failed"; + return "dependency failed"; default: return skipReason; } From 5ee1137352660fd19c8a3a2c5b7b1fad817ead9f Mon Sep 17 00:00:00 2001 From: Kapil Gupta Date: Wed, 21 Aug 2024 12:31:56 +0530 Subject: [PATCH 06/11] fix test failure --- src/buildSummary.unit.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/buildSummary.unit.test.ts b/src/buildSummary.unit.test.ts index fd1e39f..87061ef 100644 --- a/src/buildSummary.unit.test.ts +++ b/src/buildSummary.unit.test.ts @@ -23,7 +23,7 @@ describe('summaryGeneration', () => { expect(result).toEqual([ ['Task 1', '🔴 Failed', 'Task 1 description', '00:00:10'], - ['Task 2', '🔵 Skipped (User Specified)', 'Task 2 description', '00:00:20'], + ['Task 2', '🔵 Skipped (user specified)', 'Task 2 description', '00:00:20'], ['Task 3', '🟢 Success', 'Task 3 description', '00:00:30'] ]); }); From 8e7763765b820fcda04ab7cf911cddad298b2cff Mon Sep 17 00:00:00 2001 From: Kapil Gupta Date: Thu, 22 Aug 2024 10:15:11 +0530 Subject: [PATCH 07/11] Use user requested for both UserSpecified and UserRequested --- src/buildSummary.ts | 1 - src/buildSummary.unit.test.ts | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/buildSummary.ts b/src/buildSummary.ts index 55063ee..46ebdd6 100644 --- a/src/buildSummary.ts +++ b/src/buildSummary.ts @@ -31,7 +31,6 @@ export function interpretSkipReason(skipReason: string){ case "UpToDate": return "up-to-date"; case "UserSpecified": - return "user specified"; case "UserRequested": return "user requested"; case "DependencyFailed": diff --git a/src/buildSummary.unit.test.ts b/src/buildSummary.unit.test.ts index 87061ef..a9e6ebc 100644 --- a/src/buildSummary.unit.test.ts +++ b/src/buildSummary.unit.test.ts @@ -23,7 +23,7 @@ describe('summaryGeneration', () => { expect(result).toEqual([ ['Task 1', '🔴 Failed', 'Task 1 description', '00:00:10'], - ['Task 2', '🔵 Skipped (user specified)', 'Task 2 description', '00:00:20'], + ['Task 2', '🔵 Skipped (user requested)', 'Task 2 description', '00:00:20'], ['Task 3', '🟢 Success', 'Task 3 description', '00:00:30'] ]); }); From 8a3ce75fcdc7efad9948de81c86c1287ac157cbd Mon Sep 17 00:00:00 2001 From: Kapil Gupta Date: Thu, 22 Aug 2024 10:28:59 +0530 Subject: [PATCH 08/11] add a couple more unit tests --- src/buildSummary.unit.test.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/buildSummary.unit.test.ts b/src/buildSummary.unit.test.ts index a9e6ebc..f724fde 100644 --- a/src/buildSummary.unit.test.ts +++ b/src/buildSummary.unit.test.ts @@ -16,7 +16,9 @@ describe('summaryGeneration', () => { const mockBuildSummary = JSON.stringify([ { name: 'Task 1', failed: true, skipped: false, description: 'Task 1 description', duration: '00:00:10' }, { name: 'Task 2', failed: false, skipped: true, skipReason: 'UserSpecified', description: 'Task 2 description', duration: '00:00:20' }, - { name: 'Task 3', failed: false, skipped: false, description: 'Task 3 description', duration: '00:00:30' } + { name: 'Task 3', failed: false, skipped: true, skipReason: 'DependencyFailed', description: 'Task 3 description', duration: '00:00:20' }, + { name: 'Task 4', failed: false, skipped: true, skipReason: 'UpToDate', description: 'Task 4 description', duration: '00:00:20' }, + { name: 'Task 5', failed: false, skipped: false, description: 'Task 5 description', duration: '00:00:30' } ]); const result = buildSummary.getSummaryRows(mockBuildSummary); @@ -24,7 +26,9 @@ describe('summaryGeneration', () => { expect(result).toEqual([ ['Task 1', '🔴 Failed', 'Task 1 description', '00:00:10'], ['Task 2', '🔵 Skipped (user requested)', 'Task 2 description', '00:00:20'], - ['Task 3', '🟢 Success', 'Task 3 description', '00:00:30'] + ['Task 3', '🔵 Skipped (dependency failed)', 'Task 3 description', '00:00:20'], + ['Task 4', '🔵 Skipped (up-to-date)', 'Task 4 description', '00:00:20'], + ['Task 5', '🟢 Success', 'Task 5 description', '00:00:30'] ]); }); From 32f8b5f10ce5985fe6a61a680339d2d8aa9dd30e Mon Sep 17 00:00:00 2001 From: Kapil Gupta Date: Fri, 23 Aug 2024 20:49:33 +0530 Subject: [PATCH 09/11] Update properties access level --- plugins/+ciplugins/+github/BuildSummaryPlugin.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/+ciplugins/+github/BuildSummaryPlugin.m b/plugins/+ciplugins/+github/BuildSummaryPlugin.m index 1304b94..68d62e0 100644 --- a/plugins/+ciplugins/+github/BuildSummaryPlugin.m +++ b/plugins/+ciplugins/+github/BuildSummaryPlugin.m @@ -2,7 +2,7 @@ % Copyright 2024 The MathWorks, Inc. - properties + properties (Access=private) TaskDetails = {}; end From 1bed2fb768c82ff8750c05fb4a8b12d6abc011ef Mon Sep 17 00:00:00 2001 From: Kapil Gupta Date: Thu, 29 Aug 2024 10:52:31 +0530 Subject: [PATCH 10/11] update build summary table --- plugins/+ciplugins/+github/BuildSummaryPlugin.m | 6 +++--- src/buildSummary.ts | 4 ++-- src/buildSummary.unit.test.ts | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/plugins/+ciplugins/+github/BuildSummaryPlugin.m b/plugins/+ciplugins/+github/BuildSummaryPlugin.m index 68d62e0..efbaa13 100644 --- a/plugins/+ciplugins/+github/BuildSummaryPlugin.m +++ b/plugins/+ciplugins/+github/BuildSummaryPlugin.m @@ -23,21 +23,21 @@ function runTaskGraph(plugin, pluginData) function runTask(plugin, pluginData) runTask@matlab.buildtool.plugins.BuildRunnerPlugin(plugin, pluginData); - taskDetail = getCommonTaskData(pluginData); + taskDetail = getCommonTaskDetail(pluginData); plugin.TaskDetails = [plugin.TaskDetails, taskDetail]; end function skipTask(plugin, pluginData) skipTask@matlab.buildtool.plugins.BuildRunnerPlugin(plugin, pluginData); - taskDetail = getCommonTaskData(pluginData); + taskDetail = getCommonTaskDetail(pluginData); taskDetail.skipReason = pluginData.SkipReason; plugin.TaskDetails = [plugin.TaskDetails, taskDetail]; end end end -function taskDetail = getCommonTaskData(pluginData) +function taskDetail = getCommonTaskDetail(pluginData) taskDetail = struct(); taskDetail.name = pluginData.TaskResults.Name; taskDetail.description = pluginData.TaskGraph.Tasks.Description; diff --git a/src/buildSummary.ts b/src/buildSummary.ts index 46ebdd6..4c625a0 100644 --- a/src/buildSummary.ts +++ b/src/buildSummary.ts @@ -20,7 +20,7 @@ export function getSummaryRows(buildSummary: string): any[] { } else if (t.skipped) { return [t.name, '🔵 Skipped' + ' (' + interpretSkipReason(t.skipReason) + ')', t.description, t.duration]; } else { - return [t.name, '🟢 Success', t.description, t.duration]; + return [t.name, '🟢 Successful', t.description, t.duration]; } }); return rows; @@ -43,7 +43,7 @@ export function interpretSkipReason(skipReason: string){ export function processAndDisplayBuildSummary() { const runId = process.env.GITHUB_RUN_ID || ''; const runnerTemp = process.env.RUNNER_TEMP || ''; - const header = [{ data: 'MATLAB Build Task', header: true }, { data: 'Status', header: true }, { data: 'Description', header: true }, { data: 'Duration (hh:mm:ss)', header: true }]; + const header = [{ data: 'MATLAB Task', header: true }, { data: 'Status', header: true }, { data: 'Description', header: true }, { data: 'Duration (HH:mm:ss)', header: true }]; const filePath: string = join(runnerTemp, `buildSummary${runId}.json`); let taskSummaryTable; diff --git a/src/buildSummary.unit.test.ts b/src/buildSummary.unit.test.ts index f724fde..de57192 100644 --- a/src/buildSummary.unit.test.ts +++ b/src/buildSummary.unit.test.ts @@ -28,13 +28,13 @@ describe('summaryGeneration', () => { ['Task 2', '🔵 Skipped (user requested)', 'Task 2 description', '00:00:20'], ['Task 3', '🔵 Skipped (dependency failed)', 'Task 3 description', '00:00:20'], ['Task 4', '🔵 Skipped (up-to-date)', 'Task 4 description', '00:00:20'], - ['Task 5', '🟢 Success', 'Task 5 description', '00:00:30'] + ['Task 5', '🟢 Successful', 'Task 5 description', '00:00:30'] ]); }); it('writes the summary correctly', () => { const mockTableRows = [ - ['MATLAB Build Task', 'Status', 'Description', 'Duration (hh:mm:ss)'], + ['MATLAB Task', 'Status', 'Description', 'Duration (HH:mm:ss)'], ['Test Task', '🔴 Failed', 'A test task', '00:00:10'], ]; From c07899abc261e93bececb25b691921482eaa683a Mon Sep 17 00:00:00 2001 From: Kapil Gupta Date: Fri, 30 Aug 2024 09:01:16 +0530 Subject: [PATCH 11/11] update status to succeeded --- src/buildSummary.ts | 2 +- src/buildSummary.unit.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/buildSummary.ts b/src/buildSummary.ts index 4c625a0..927fba9 100644 --- a/src/buildSummary.ts +++ b/src/buildSummary.ts @@ -20,7 +20,7 @@ export function getSummaryRows(buildSummary: string): any[] { } else if (t.skipped) { return [t.name, '🔵 Skipped' + ' (' + interpretSkipReason(t.skipReason) + ')', t.description, t.duration]; } else { - return [t.name, '🟢 Successful', t.description, t.duration]; + return [t.name, '🟢 Succeeded', t.description, t.duration]; } }); return rows; diff --git a/src/buildSummary.unit.test.ts b/src/buildSummary.unit.test.ts index de57192..aeee551 100644 --- a/src/buildSummary.unit.test.ts +++ b/src/buildSummary.unit.test.ts @@ -28,7 +28,7 @@ describe('summaryGeneration', () => { ['Task 2', '🔵 Skipped (user requested)', 'Task 2 description', '00:00:20'], ['Task 3', '🔵 Skipped (dependency failed)', 'Task 3 description', '00:00:20'], ['Task 4', '🔵 Skipped (up-to-date)', 'Task 4 description', '00:00:20'], - ['Task 5', '🟢 Successful', 'Task 5 description', '00:00:30'] + ['Task 5', '🟢 Succeeded', 'Task 5 description', '00:00:30'] ]); });