From df25dfae85e8d30504ee1489f20efd53437ffa2e Mon Sep 17 00:00:00 2001 From: Jinzhe Zeng Date: Thu, 29 Aug 2024 16:10:26 -0400 Subject: [PATCH] Remove the skip mark for test_delta_func (#4014) * recover test_delta_func Signed-off-by: Jinzhe Zeng * pre-commit auto-fixes * bump scipy for Windows * add comments to pyproject.toml * pre-commit auto-fixes --------- Signed-off-by: Jinzhe Zeng Co-authored-by: Janosh Riebesell --- pyproject.toml | 3 +++ tests/io/vasp/test_optics.py | 6 ------ 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index 619f8a25ccf..403b394ed9f 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -66,6 +66,9 @@ dependencies = [ "requests>=2.32", "ruamel.yaml>=0.17.0", "scipy>=1.13.0", + # scipy<1.14.1 is incompatible with NumPy 2.0 on Windows + # https://github.com/scipy/scipy/issues/21052 + "scipy>=1.14.1; platform_system == 'Windows'", "spglib>=2.5.0", "sympy>=1.2", "tabulate>=0.9", diff --git a/tests/io/vasp/test_optics.py b/tests/io/vasp/test_optics.py index 3790a57b98f..3a2caf7a94a 100644 --- a/tests/io/vasp/test_optics.py +++ b/tests/io/vasp/test_optics.py @@ -1,7 +1,5 @@ from __future__ import annotations -import sys - import numpy as np import pytest import scipy.special @@ -53,10 +51,6 @@ def test_optics(self): assert len(x_val) == len(y_val) == len(text) -@pytest.mark.skipif( - sys.platform == "win32" and int(np.__version__[0]) >= 2, - reason="Fails on Windows with numpy > 2.0.0, awaiting https://github.com/scipy/scipy/issues/21052 resolution", -) def test_delta_func(): x = np.array([0, 1, 2, 3, 4, 5])