Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API should return error on unsupported fields #835

Closed
shyuep opened this issue Aug 10, 2023 · 1 comment
Closed

API should return error on unsupported fields #835

shyuep opened this issue Aug 10, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@shyuep
Copy link
Member

shyuep commented Aug 10, 2023

mpr.materials._search(nelements=2, fields=["material_id", "final_structure"]) simply returns the material_id and the final_structure is ignored. This is generally not a good behavior for people to learn that final_structure is not actually a supported field for materials.

@munrojm
Copy link
Member

munrojm commented Aug 10, 2023

I agree with this, we should check all fields requested against MPRester.*.available_fields and notify people if anything they ask for is invalid.

@munrojm munrojm added the enhancement New feature or request label Aug 10, 2023
@munrojm munrojm self-assigned this Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants