Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dialog] Dialog don't follow M3 specs #8192

Open
neo-xy opened this issue Jun 18, 2024 · 1 comment
Open

[Dialog] Dialog don't follow M3 specs #8192

neo-xy opened this issue Jun 18, 2024 · 1 comment
Labels

Comments

@neo-xy
Copy link

neo-xy commented Jun 18, 2024

Bug report

Dialog background is not following M3 sepcs-> should be surface-container-high but it's not.
(if it should not follow - can we know the reason why?)

Steps to reproduce

Issue first was reported here: angular/components#29230
but angular-components team "linked" it here.
!!! If corrected please inform Angular-components team about it !!!

Actual behavior

background is of different color then specified in docs (much more lighter)

Expected behavior

background should be set to surface-container-high as per docs: https://m3.material.io/components/dialogs/specs
which is the one thta is used in M3 Figma components

Your Environment:

Software Version(s)
MDC Web
Browser Chrome
Operating System MacOs

Possible solution

Change dialog bg to be set to surface-container-high and Inform Angular-components team about it
(I am guessing that You are using "old" veriation of "surface" colors so the issue may exists in other components as well)

@neo-xy neo-xy added the bug label Jun 18, 2024
@anentropic
Copy link

anentropic commented Jul 5, 2024

I think this lib is M2 only

the M3 web components are found at https://github.com/material-components/material-web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants