This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(text-field): Do not trigger shake animation when text field is empty #5097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhiomkar
force-pushed
the
fix/textfield/shake_empty
branch
from
4e45ff9 to
e4c5c0d
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5097 +/- ##
========================================
Coverage 98.67% 98.67%
========================================
Files 122 122
Lines 6032 6032
Branches 796 796
========================================
Hits 5952 5952
Misses 79 79
Partials 1 1
Continue to review full report at Codecov.
|
|
All 737 screenshot tests passed for commit e4c5c0d vs. |
joyzhong
approved these changes
Sep 17, 2019
abhiomkar
force-pushed
the
fix/textfield/shake_empty
branch
from
e4c5c0d to
688b8dd
Compare
|
All 737 screenshot tests passed for commit 688b8dd vs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4919