Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu): Fix bug where TAB does not respect the default browser tab order. #4789

Merged
merged 9 commits into from
Jun 4, 2019

Conversation

joyzhong
Copy link
Contributor

@joyzhong joyzhong commented Jun 4, 2019

No description provided.

Copy link
Collaborator

@abhiomkar abhiomkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Reviewed this with previous branch's diff)

Looks good overall. Left minor comments.

packages/mdc-menu/adapter.ts Show resolved Hide resolved
packages/mdc-menu/foundation.ts Outdated Show resolved Hide resolved
@mdc-web-bot
Copy link
Collaborator

All 690 screenshot tests passed for commit 7d031b1 vs. develop! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 690 screenshot tests passed for commit a20d03e vs. develop! 💯🎉

@codecov-io
Copy link

codecov-io commented Jun 4, 2019

Codecov Report

Merging #4789 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4789      +/-   ##
===========================================
+ Coverage    98.95%   98.95%   +<.01%     
===========================================
  Files          129      129              
  Lines         6309     6312       +3     
  Branches       812      813       +1     
===========================================
+ Hits          6243     6246       +3     
  Misses          65       65              
  Partials         1        1
Impacted Files Coverage Δ
packages/mdc-menu-surface/foundation.ts 100% <100%> (ø) ⬆️
packages/mdc-menu-surface/component.ts 100% <100%> (ø) ⬆️
packages/mdc-menu/foundation.ts 96.25% <100%> (ø) ⬆️
packages/mdc-menu/component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99af567...c539af6. Read the comment docs.

@mdc-web-bot
Copy link
Collaborator

All 690 screenshot tests passed for commit c539af6 vs. develop! 💯🎉

@joyzhong joyzhong merged commit fac4c43 into develop Jun 4, 2019
@joyzhong joyzhong deleted the fix/menu_taborder branch June 4, 2019 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants