Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix(select): Fix enhanced select issue where it does not stay open on long press #4173 #4590

Merged
merged 6 commits into from
Apr 15, 2019
Merged

fix(select): Fix enhanced select issue where it does not stay open on long press #4173 #4590

merged 6 commits into from
Apr 15, 2019

Conversation

moog16
Copy link
Contributor

@moog16 moog16 commented Apr 11, 2019

continuation of #4413
fixes #4173

shelart and others added 2 commits February 14, 2019 12:58
@shelart
fix(MDCSelect): issue #4173
46f245c 
Fix Enhanced MDCSelect behaviour on touch screens/desktops with touchpad
Merge branch 'master' of https://github.com/shelart/material-componen…
a0225d0 
…ts-web into shelart-master
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

abhiomkar
abhiomkar reviewed Apr 11, 2019
View reviewed changes
packages/mdc-select/component.ts Outdated
@@ -37,9 +37,9 @@ import {MDCSelectHelperText, MDCSelectHelperTextFactory} from './helper-text/ind
import {MDCSelectIcon, MDCSelectIconFactory} from './icon/index';
import {MDCSelectEventDetail, MDCSelectFoundationMap} from './types';

type PointerEventType = 'mousedown' | 'touchstart';
type PointerEventType = 'click';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We not longer need POINTER_EVENTS & PointerEventType since this is only single event, we can directly add register it to handleClick foundation method without looping through POINTER_EVENTS.

@mdc-web-bot
Copy link
Collaborator

All 636 screenshot tests passed for commit a0225d0 vs. master! 💯🎉

abhiomkar
abhiomkar approved these changes Apr 11, 2019
View reviewed changes
Copy link
Collaborator

@abhiomkar abhiomkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@abhiomkar abhiomkar changed the title fix(MDCSelect): issue #4173 fix(MDCSelect): Fix enhanced select issue where it does not stay open on long press #4173 Apr 11, 2019
@abhiomkar abhiomkar changed the title fix(MDCSelect): Fix enhanced select issue where it does not stay open on long press #4173 fix(select): Fix enhanced select issue where it does not stay open on long press #4173 Apr 11, 2019
@moog16
Copy link
Contributor Author

moog16 commented Apr 11, 2019

@shelart could you comment here and say "I signed it" please

@mdc-web-bot
Copy link
Collaborator

All 636 screenshot tests passed for commit ef4188f vs. master! 💯🎉

@shelart
Copy link

shelart commented Apr 12, 2019

I signed it

@moog16 moog16 added cla: yes and removed cla: no labels Apr 12, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@moog16 moog16 added cla: yes and removed cla: no labels Apr 12, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@mdc-web-bot
Copy link
Collaborator

All 636 screenshot tests passed for commit 87128b4 vs. master! 💯🎉

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@moog16 moog16 removed the cla: no label Apr 15, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@mdc-web-bot
Copy link
Collaborator

All 636 screenshot tests passed for commit b0b7a7d vs. master! 💯🎉

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@moog16 moog16 added cla: yes and removed cla: no labels Apr 15, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@mdc-web-bot
Copy link
Collaborator

All 636 screenshot tests passed for commit 55fb65a vs. master! 💯🎉

@moog16 moog16 merged commit 8286aa7 into master Apr 15, 2019
@moog16 moog16 deleted the shelart-master branch April 15, 2019 22:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abhiomkar abhiomkar abhiomkar approved these changes

Assignees

@abhiomkar abhiomkar

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhanced select menu doesn't stay open
5 participants
@moog16 @googlebot @mdc-web-bot @shelart @abhiomkar